Skip to content

Conversation

APiligrim
Copy link
Contributor

@APiligrim APiligrim commented Aug 29, 2025

This PR creates a testbed for embed service to test different states of embeds for this ticket.

Screen.Recording.2025-08-29.at.12.59.16.AM.mov

Screenshots
Screenshot 2025-08-29 at 5 09 29 PM
Screenshot 2025-08-29 at 5 13 58 PM

@APiligrim APiligrim marked this pull request as ready for review August 30, 2025 00:14
</blockquote>
<script
async
src="https://embed.bsky.app/static/embed.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this uses the production code. it would be much more helpful if we could see the output of the dev server instead

@elijaharita elijaharita force-pushed the @APiligrim/test-embeds branch from 801b6b4 to ac3c9b9 Compare September 29, 2025 17:12
@mozzius
Copy link
Member

mozzius commented Sep 29, 2025

Seems there was an image committed by accident? Also, no need to run the intl:extract script, that happens automatically

@elijaharita elijaharita force-pushed the @APiligrim/test-embeds branch from a127af2 to 1338fcb Compare September 30, 2025 00:49
Copy link
Collaborator

@jimmylee jimmylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks like we can finally test Bluesky embeds. I'll wait for @mozzius to also give a thumbs up just in case I missed something.

@mozzius
Copy link
Member

mozzius commented Sep 30, 2025

Close, but it points to a locally running bskyweb instance, whereas ideally it's pointing at the vite devserver.

I managed to get that working in #9115, so I will close this PR.

@mozzius mozzius closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants