🛡️ Sentinel: Fix shell injection and password handling in entrypoint#25
Conversation
- Use `read -r` to prevent backslash interpretation in variable processing. - Quote variables in `adduser` call to prevent word splitting and globbing. - Use `set -f` (noglob) when executing dynamic `vpncmd` commands to prevent file path disclosure/injection while preserving argument splitting. - Add regression test `tests/test_entrypoint_injection.sh`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
🛡️ Sentinel: [CRITICAL/HIGH] Fix command injection and password truncation
🚨 Severity: HIGH
💡 Vulnerability:
adduserarguments allowed passwords with spaces to be truncated (only first word used).*), causing file names to be injected as passwords or command arguments.readwithout-rconsumed backslashes in passwords.🎯 Impact:
*could be replaced by file names from the container's file system, leading to unauthorized access or denial of service.🔧 Fix:
read -rflag.set -f/set +fto disable globbing safely.✅ Verification:
tests/test_entrypoint_injection.shwhich mocksvpncmdand verifies that spaces, backslashes, and glob characters are preserved correctly.PR created automatically by Jules for task 16140805324010560972 started by @bluPhy