🛡️ Sentinel: Fix shell injection vulnerabilities in entrypoint.sh

[google-labs-jules]

🛡️ Sentinel: Fix shell injection vulnerabilities in entrypoint.sh

🚨 Severity: HIGH
💡 Vulnerability: Shell Command Injection / Argument Injection
The copyables/entrypoint.sh script processed user input (USERS, VPNCMD_SERVER, VPNCMD_HUB) using unquoted variables and read without -r.
This allowed:

1. Passwords with spaces to be truncated (due to word splitting).
2. Passwords with backslashes to be corrupted (due to escape interpretation).
3. Command arguments containing * to be expanded into filenames (globbing), causing unexpected behavior or information leakage.

🔧 Fix:

1. Quoted $username and $password in adduser calls.
2. Added -r to all read commands.
3. Wrapped VPNCMD command execution loops in set -f and set +f to safely allow word splitting (for command parsing) while preventing globbing.

✅ Verification:
Added tests/test_entrypoint_injection.sh which mocks the environment and asserts that:

• Passwords with spaces are preserved.
• Passwords with backslashes are preserved.
• Wildcards * are passed literally and not expanded.

Tests passed successfully.

---

PR created automatically by Jules for task 8426994037787046123 started by @bluPhy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}