Conversation
brunod-e
requested review from
LeonardoVieira1630,
PedroBinotto,
alextnetto,
isadorable-png and
pikonha
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f8a84bcd2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| import daoConfigByDaoId from "@/shared/dao-config"; | ||
| import type { DaoIdEnum } from "@/shared/types/daos"; | ||
|
|
||
| const ETH_ADDRESS_REGEX = /(0x[0-9a-fA-F]{40})(?![0-9a-fA-F])/g; |
There was a problem hiding this comment.
The new ETH_ADDRESS_REGEX only checks the right boundary, so it can match the last 40 hex chars inside longer values (for example a 64-hex bytes32 hash) and treat them as Ethereum addresses. In decoded calldata that includes hashes or packed bytes, this will render incorrect ENS names and mutate the displayed payload, which can mislead users reviewing proposal actions.
Useful? React with 👍 / 👎.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
brunod-e
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f8a84bcd2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const isQueued = | ||
| proposalStatus === "queued" || | ||
| proposalStatus === "pending_execution" || | ||
| proposalStatus === "executed"; |
There was a problem hiding this comment.
The timeline logic omits succeeded from isQueued, so proposals that are now labeled as pending queue never render a queued milestone at all. In practice, when a proposal has passed but not yet been queued, the UI stops at Ended, which misrepresents the current workflow stage and makes it look like nothing remains. This should treat succeeded as a queued-stage proposal (with pending state) so the timeline matches the status shown elsewhere.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb10db3f33
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| proposalStatus === "queued" || | ||
| proposalStatus === "pending_execution" || | ||
| proposalStatus === "executed"; |
There was a problem hiding this comment.
The queued milestone is gated only on queued, pending_execution, and executed, so proposals with status expired render without any queued step even though expiration occurs after queueing in governor flows. In that case the timeline regresses to Created/Started/Ended and hides the stage where execution failed to happen before expiry, which misrepresents proposal progression for users troubleshooting why a passed proposal was never executed.
Useful? React with 👍 / 👎.
isadorable-png
left a comment
isadorable-png
left a comment
There was a problem hiding this comment.
- Missing voting power on didn't vote tab
- Big links are breaking the layout, still needs fixing
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ae67ceb61
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <EnsAvatar | ||
| key={`ens-${i}`} | ||
| address={segment as `0x${string}`} | ||
| showAvatar={false} | ||
| nameClassName="text-secondary font-mono text-sm font-normal not-italic leading-5" |
There was a problem hiding this comment.
Rendering decoded calldata addresses through EnsAvatar without showFullAddress causes unresolved addresses to be shortened (e.g. 0x1234…abcd) instead of showing the exact 42-char value, so proposal actions can display ambiguous or indistinguishable recipients when multiple addresses share the same prefix/suffix. This regresses the fidelity of the calldata viewer and can mislead users validating execution targets even though the copied text still contains full addresses.
Useful? React with 👍 / 👎.
2 participants
https://app.clickup.com/t/90132341641/DEV-468