[DEV-475] Composite dao endpoint for header metrics#1701
[DEV-475] Composite dao endpoint for header metrics#1701PedroBinotto wants to merge 8 commits intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
…icapture into feat/composite-dao-endpoint
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
PedroBinotto
requested review from
LeonardoVieira1630 and
pikonha
as code owners
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
PedroBinotto
changed the title
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50420bc886
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2689176f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b906f405a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| root, | ||
| args: { fetchGovernanceData }, | ||
| context, | ||
| info, |
There was a problem hiding this comment.
info here belongs to the daos field (DAOList), but it is being forwarded to client.dao, which resolves a different field shape (dao_200_response). In Mesh delegation this can cause the delegated call to project the wrong selection set and reject; because this resolver uses Promise.allSettled and drops rejected results, affected requests can silently return partial/empty DAO lists instead of surfacing an error. Keep the explicit selectionSet and avoid passing the parent info object when delegating to another field.
Useful? React with 👍 / 👎.
1 participant
No description provided.