Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
isadorable-png
left a comment
isadorable-png
left a comment
There was a problem hiding this comment.
- Stage badge is not aligned.
- Use the tab of default size (font should be 14px).
- Also add a minimum width to the badge so it can be a "square" - the "1" badge is looking weird.
- remove this extra gap on the title.
- Aave token value is wrong, it not $0, but $113.00
- Links on the right side are also wrong, please correct it. It does not make sense "aave" and "aave".
- The bottom row should have a "fill" behavior, otherwise there will be a empty space below, check example:
---
- Is this using the correct blank slate component? it seems a bit off and the paragraph line height is wrong. It should be 20px, otherwise is kinda hard to read.
- If the balance is 0, show 0. Not "-".
- Why is delegates table different from what we have now?
- We don't show balance, delegation received is called "voting power".
- What is "total"?
- Balance sorting is not working.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4860b051b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .onConflictDoUpdate((current) => ({ | ||
| amount: current.amount + value, | ||
| })); |
There was a problem hiding this comment.
aaveTransfer is called for AAVE, stkAAVE, and aAAVE events, but this upsert merges rows on conflict by adding amount without preserving token separation. Because transfers are keyed by (transactionHash, fromAccountId, toAccountId), two transfers of different AAVE token variants between the same accounts in one transaction collapse into one row with a summed amount and the first token's metadata, which corrupts transfer history and downstream token-level reporting.
Useful? React with 👍 / 👎.
| conditions.push( | ||
| gt(accountBalance.balance, BigInt(amountfilter.minAmount)), | ||
| ); |
There was a problem hiding this comment.
This repository returns account-level balances by summing multiple token rows, but the amount filter is applied to each individual account_balance.balance row before aggregation. For AAVE accounts split across AAVE/stkAAVE/aAAVE, fromValue/toValue can exclude valid accounts (or partially include balances) even when their combined balance satisfies the filter, so /balances responses become inconsistent with the returned aggregated balance field.
Useful? React with 👍 / 👎.
| addresses: delegateAddresses, | ||
| limit: delegateAddresses.length || 1, | ||
| }, |
There was a problem hiding this comment.
The delegate balance lookup sets limit to delegateAddresses.length, so after enough infinite-scroll pages this will exceed the backend /balances limit cap (100) defined in the account-balance request schema. At that point the balance query fails validation, and the table falls back to zero balances, which makes the displayed balance/delegation split incorrect for loaded delegates.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8715f64208
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| orderBy === "variation" | ||
| ? sql`ABS(COALESCE(${variationSubquery.absoluteChange}, 0))` | ||
| : orderBy === "signedVariation" | ||
| ? orderDirectionFn( |
There was a problem hiding this comment.
When orderBy is signedVariation, this branch already applies orderDirectionFn(...), but the whole expression is then wrapped by orderDirectionFn(...) again at line 201. That produces a double direction modifier (ASC ASC / DESC DESC) for the generated SQL, so AAVE /voting-powers requests with orderBy=signedVariation can fail instead of returning results (the delegates table uses this sort mode in its variation toggle).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5715fa07ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| historicalVotingPower(app, votingPowerService); | ||
| votingPowers(app, votingPowerService); | ||
| accountBalances(app, env.DAO_ID, accountBalanceService); | ||
| transfers(app, new TransfersService(new TransfersRepository(pgClient))); | ||
| dao(app, daoService); |
There was a problem hiding this comment.
This entrypoint only mounts balances/voting/delegation/transfer/dao routes, but the AAVE overview page still executes useDaoOverviewData (useTokenData, useActiveSupply, useAverageTurnout, and treasury queries) from apps/dashboard/features/dao-overview/hooks/useDaoOverviewData.ts. In apps/api-gateway/src/resolvers/rest.ts, missing DAO routes cause targetClient[fieldName] to throw Endpoint ... is not available, so /aave overview requests fail and metrics silently degrade to fallback zeros (for example token price/treasury values).
Useful? React with 👍 / 👎.
| if (activeTab === TABS.FULLY_ANALYZED) { | ||
| return ( | ||
| <ActiveTokensCell | ||
| daoId={row.getValue("dao") as DaoIdEnum} |
There was a problem hiding this comment.
The activeTokensSort map is populated only when ActiveTokensCell renders, but this branch is skipped on the Not Reviewed tab while sorting remains enabled for the same column. After switching tabs, sorting by "Active Tokens in Governance" reads stale row-index values from the previous tab (createSortingFn(activeTokensSort)), so Not Reviewed rows are ordered by unrelated data instead of their current state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39d399bd67
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| historicalVotingPower(app, votingPowerService); | ||
| votingPowers(app, votingPowerService); | ||
| accountBalances(app, env.DAO_ID, accountBalanceService); | ||
| transfers(app, new TransfersService(new TransfersRepository(pgClient))); |
There was a problem hiding this comment.
The new AAVE holders page still renders the token-holder drawer's TopInteractions tab (via HoldersAndDelegatesDrawer), and that tab calls the accountInteractions GraphQL query, but this entrypoint never mounts the accountInteractions controller. In practice, opening that tab for AAVE yields an endpoint-not-available error from the gateway instead of interaction data. Please either register accountInteractions(...) in this server or explicitly disable that tab for AAVE.
Useful? React with 👍 / 👎.
| offchainProposalById(id: String!): offchainProposalById_200_response | ||
|
|
||
| """Returns a list of offchain (Snapshot) votes""" | ||
| votesOffchain(skip: NonNegativeInt, limit: Float = 10, orderBy: queryInput_votesOffchain_orderBy = timestamp, orderDirection: queryInput_votesOffchain_orderDirection = desc, voterAddresses: JSON, fromDate: Float, toDate: Float): votesOffchain_200_response |
There was a problem hiding this comment.
These new schema fields expose offchain vote queries, but apps/api-gateway/src/resolvers/rest.ts does not include votesOffchain or votesOffchainByProposalId in daoItemQueries (it only includes offchainProposals/offchainProposalById). That means the new vote fields skip the per-DAO dispatch path that uses anticapture-dao-id, so in multi-DAO deployments they can resolve against the wrong backing DAO source. Add both vote fields to the DAO-dispatched resolver list.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4505735b38
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| `, | ||
| balance: balanceSubquery.totalBalance, | ||
| }) | ||
| .from(accountPower) |
There was a problem hiding this comment.
/voting-powers/{accountId} currently reads from accountPower only, so any AAVE address that has wallet balance but no account_power row falls into the zero-value fallback even though the list endpoint includes it via balance data. In practice this makes account-level voting power lookups inconsistent with /voting-powers and returns incorrect zeros for holder addresses in views that call votingPowerByAccountId.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca7cf73da1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| await context.db.insert(token).values({ | ||
| id: address, | ||
| name: daoId, | ||
| decimals, |
There was a problem hiding this comment.
This setup stores all three AAVE-family contracts with the same token.name (daoId), but the API still resolves token properties by name via TokenRepository.getTokenPropertiesByName() (findFirst on token.name). After indexing AAVE + stkAAVE + aAAVE, /token (and overview token metrics that depend on it) can read an arbitrary row instead of a deterministic/combined value, producing unstable or incorrect token stats.
Useful? React with 👍 / 👎.
| .onConflictDoUpdate((current) => ({ | ||
| delegationsCount: current.delegationsCount + 1, | ||
| votingPower: current.votingPower + delegatorBalance.balance, |
There was a problem hiding this comment.
This increments delegationsCount on every AAVE DelegateChanged event, but aaveDelegateChanged is wired for v3AAVE, v3stkAAVE, and v3aAAVE. A single wallet delegating multiple AAVE token variants to the same delegate will be counted multiple times, so delegationsCount (used by /voting-powers and the dashboard “Delegators” column) no longer represents unique delegator accounts.
Useful? React with 👍 / 👎.
3 participants
No description provided.