You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall the implementation is clean and well-structured. Here are a few observations:
Issues / Suggestions
VERCEL_URL is the deployment URL, not the production URL (apps/dashboard/app/sitemap.ts:8-9)
VERCEL_URL resolves to the unique deployment URL (e.g., anticapture-git-feat-xxx.vercel.app), which changes per deployment. For the production URL, use VERCEL_PROJECT_PRODUCTION_URL instead. This matters because search engines will index the production URL and the sitemap should consistently point there.
panel page is missing from the sitemap (apps/dashboard/app/sitemap.ts:24-61)
PAGES_CONSTANTS.panel.page ("panel") is defined but not included in staticPages. Is this intentional (e.g., requires authentication)? If it's public-facing it should be included for SEO.
Fragile "/" check for DAO overview (apps/dashboard/app/sitemap.ts:67-69)
The check subPage === "/" relies on the internal string value of PAGES_CONSTANTS.daoOverview.page. If that value changes, URL construction silently breaks. Consider using a constant or comparing against the constant itself:
lastModified: new Date() reflects generation time, not content change time
This is a common tradeoff and acceptable here since the pages don't have trackable last-edit timestamps. No action needed, just worth being aware that search engines may re-crawl more frequently than necessary.
What looks good
Correct use of MetadataRoute.Sitemap type from Next.js
Sensible priority values (homepage at 1.0, DAO overview pages at 0.9, sub-pages at 0.8)
Using ALL_DAOS to enumerate DAO pages dynamically keeps the sitemap in sync with new DAOs
The as const assertion on changeFrequency in daoSubPages.map avoids type widening to string
Clean separation between staticPages and daoPages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86af01e5m