Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PedroBinotto
changed the title
pikonha
requested review from
LeonardoVieira1630,
brunod-e,
isadorable-png and
pikonha
as code owners
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dadcda0ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export const ShutterIcon = (_props: DaoIconProps) => { | ||
| return ( | ||
| <svg |
There was a problem hiding this comment.
ShutterIcon ignores its DaoIconProps (_props) and never forwards them to the <svg>. DaoAvatarIcon depends on forwarding these props to apply size/class styling and showBackground, so SHU avatars render with fixed dimensions and miss expected styling behavior anywhere the shared avatar component is used.
Useful? React with 👍 / 👎.
pikonha
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e3fb9979d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| againstVotes: bigint; | ||
| abstainVotes: bigint; | ||
| }): bigint { | ||
| return votes.forVotes + votes.abstainVotes + votes.abstainVotes; |
There was a problem hiding this comment.
calculateQuorum currently returns forVotes + abstainVotes + abstainVotes, which drops againstVotes entirely and counts abstentions twice. GovernorBase.getProposalStatus uses this value to decide quorum, so SHU proposals can be marked with the wrong final status (for example, abstain-heavy proposals can satisfy quorum too easily, while participation concentrated in againstVotes can be undercounted).
Useful? React with 👍 / 👎.
| }, | ||
| [DaoIdEnum.ARB]: {}, | ||
| [DaoIdEnum.OP]: {}, | ||
| [DaoIdEnum.SHU]: {}, |
There was a problem hiding this comment.
The SHU entry is an empty object, so account-balance listings pass no treasury exclusions for this DAO and treasury-controlled wallets are treated as regular holders in ranking/variation responses. In the same commit SHU timelock/treasury addresses are introduced elsewhere, so this omission will skew SHU holder-facing metrics unless those addresses are excluded here too.
Useful? React with 👍 / 👎.
2 participants
No description provided.