fix: rename progressPct to historicalSyncProgressPct in sync-progress API#90
fix: rename progressPct to historicalSyncProgressPct in sync-progress API#90lgahdl wants to merge 2 commits into
Conversation
… API Makes the field name self-documenting — it clearly tracks historical block-fetch progress (not handler completion), consistent with the distinction between progressPct=100 and isComplete=false. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documentation / CI review
Lines 56, 63, and 70 of
All three should be changed to OpenAPI/Swagger ( No other docs files affected. Overall: One actionable item before merge — update the three occurrences of |
|
Review: Rename progressPct → historicalSyncProgressPct The rename is complete across all four affected locations:
No remaining references to This PR is clean. |
…eld name Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| ``` | ||
|
|
||
| - `progressPct` is rounded to one decimal place (0–100). | ||
| - `historicalSyncProgressPct` is rounded to one decimal place (0–100). |
There was a problem hiding this comment.
historicalSyncProgressPct is not clear yet for me.
I would prefer something like historicalBlocksFetchedPct
There was a problem hiding this comment.
can't we add then a historicalBlocksProcessedPct as well?
Summary
progressPct→historicalSyncProgressPctin theGET /api/sync-progressresponse schema, endpoint implementation, route description, and test assertionsMotivation
The old name was ambiguous —
progressPct: 100whileisComplete: falselooked contradictory. The new name makes it self-documenting: it tracks historical block-fetch progress (eth_getLogs layer), not handler execution completion.Test plan
pnpm typecheckpasses (verified locally)pnpm testpasses — all 31 tests green (verified locally)🤖 Generated with Claude Code