Conversation
…ing for each subsession is not uniform
…d group_survey functionality
…d group_survey functionality
joshbenhamou
left a comment
joshbenhamou
left a comment
There was a problem hiding this comment.
Can you share a little about what the goal of this MR is? It's hard to review this without context
|
|
||
| public static function initializeMemoryTasks($group_id, $randomize,$final,$test) { | ||
| if($final){ | ||
| $taskArray = '[ |
There was a problem hiding this comment.
Why is this all stringified?
There was a problem hiding this comment.
This is a major holdover from Gabe's design that I chose to integrate rather than rebuild. I think if I had to justify why he did it this way, it's because we have generalized tables for GroupTasks and IndividualTasks, all of which have different subtypes (for instance, cryptography vs memory), and each subtype has some parameters that don't overlap with the other subtypes. So I think in order to avoid a prohibitively wide table and to keep these parameters accessible in a generalized way, he stringified these arrays so he could store them in one column called "parameters"
There was a problem hiding this comment.
I see okay, thanks for clarifying. Figured that this was a holdover but was curious about it
…ity (no longer interferes with active study to lock login page)
2 participants
No description provided.