Introducing phpspec for test coverage.#3
Open
Richtermeister wants to merge 1 commit intobkuhl:masterfrom
Open
Conversation
Contributor
Author
|
Ok, cool. So if I switch this to the "real" xml from the UPS api, and wrap the fixture loading into a re-usable class, this direction is acceptable? Have a great weekend! 😃 |
Owner
|
Yeah, I'd say go for it. |
Owner
|
@Richtermeister I'm considering some overhauling on this package to make it more testable and add a Laravel service provider and some other things. Do you have any more phpspec work that hasn't been pushed up for this? |
Contributor
Author
|
Hey Ben, I currently don't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a baby-step to introduce test coverage. phpSpec is an up-and-coming testing methodology with rapid growth of adoption over phpUnit.
If this approach is acceptable I would be happy to add more such tests, including realistic fixtures based on real UPS api responses.