use gmake file function for response files - #593
Conversation
Current implementation relies on external echo command, which suffers from the same command line length limits the response files are designed to work around. The file function avoids this problem and theoretically performs better.
|
What about Right now it's possible to do |
There was a problem hiding this comment.
Pull request overview
This PR updates the GNU make (“gmake”) C/C++ project generator to emit response files using GNU make’s built-in $(file ...) function instead of invoking an external echo, aiming to avoid shell command-line length limits when generating @response files.
Changes:
- Replace
echo $^ > $@response-file generation with$(file >$@,$^)for object response files. - Replace
echo $^ > $@response-file generation with$(file >$@,$^)for linker dependency response files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There is no built-in ability in gmake to "echo" built-in functions to my knowledge. The previous |
- display response files (as before, but avoiding echo) - guard file function output against dry-run option
|
|
If you can tell me how you'd like the output to appear, I can implement something to produce it, but it's going to be an additional function call and logic to achieve that, the statements from which will not themselves show up when using Do you want it to output something like: |
|
Just run |
I understand perfectly the role of the Because there's no default output or interpretation that can be used to show what the step is doing, some representation has to be programmatically generated if required, in this case probably using another built-in function such as |
Current implementation relies on external
echocommand, which suffers from the same command line length limits the response files are designed to work around. Thefilefunction avoids this problem and theoretically performs better.