Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 21, 2025

🎟️ Tracking

PM-27202

📔 Objective

This PR updates the ItemListingScreen in order to apply the correct spacing between elements. Additionally, I made the expanding headers uppercase to match generic headers.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the PM-27202-item-listing-screen-spacing branch 2 times, most recently from 1b3759c to b5a1e0f Compare October 21, 2025 20:13
@david-livefront david-livefront force-pushed the PM-27202-item-listing-screen-spacing branch from b5a1e0f to 7216094 Compare October 21, 2025 20:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Logo
Checkmarx One – Scan Summary & Details34ec211b-d1f3-4c8a-b4e2-d5dc004fae51

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.23%. Comparing base (ae4b398) to head (7216094).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...enticator/feature/itemlisting/ItemListingScreen.kt 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6065      +/-   ##
==========================================
- Coverage   84.79%   84.23%   -0.56%     
==========================================
  Files         720      836     +116     
  Lines       54957    57353    +2396     
  Branches     7636     7683      +47     
==========================================
+ Hits        46601    48313    +1712     
- Misses       5684     6353     +669     
- Partials     2672     2687      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 92cfce1 Oct 22, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-27202-item-listing-screen-spacing branch October 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants