Skip to content

Public faucet registered accounts use the same active and memo key? #3749

Description

@grctest

Describe the bug

When registering an account using the public faucet, the active and memo keys used are the same in the code

To Reproduce

Check out the code:

memo_key: active_private.private_key

memo_key: active_private.private_key
    .toPublicKey()
    .toPublicKeyString(),
//"memo_key": memo_private.private_key.toPublicKey().toPublicKeyString(),

Expected behavior

The memo key should be based on the memo_private key converted to a public key string.

This was previously an issue elsewhere in the client: #1569

However as shown in the above code, the fix seems to have been applied to self-created accounts, but not public faucet registered accounts?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions