Fix string CLI arguments being passed through JSON.parse#1
Merged
Conversation
String option values (e.g. --query "Netflix", --product_id "steam-usa") were falling through to the default case in coerceValue which called JSON.parse, causing parse errors. Now only object/array types use JSON.parse; all other types return the raw string. Also fixes incorrect command names in README (underscores → hyphens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first
Summary
coerceValueso string option values (e.g.--query "Netflix",--product_id "steam-usa") are returned as-is instead of being passed throughJSON.parse, which threw parse errorsobjectandarraytypes now useJSON.parse; all other types (includingstringand untyped properties) return the raw valueget_product_details→get-product-details,buy_products→buy-products)Test plan
bitrefill search-products --query "Netflix"returns resultsbitrefill get-product-details --product_id "steam-usa" --currency USDCreturns product detailsbitrefill list-ordersreturns ordersbitrefill list-invoicesreturns invoicesbitrefill get-invoice-by-id --invoice_id <id>returns invoicebitrefill get-order-by-id --order_id <id>returns order