Skip to content

Theme: Fix - Replace null with unspecified to standardize system default handling#2160

Open
cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/reset-all-settings-03
Open

Theme: Fix - Replace null with unspecified to standardize system default handling#2160
cmgustavo wants to merge 1 commit into
bitpay:developfrom
cmgustavo:bug/reset-all-settings-03

Conversation

@cmgustavo
Copy link
Copy Markdown
Member

@cmgustavo cmgustavo commented May 6, 2026

RN-2674

Changes

  • Replaces all usages of null as the "system default" color scheme value with 'unspecified', aligning with the updated ColorSchemeName type in React Native ('light' | 'dark' | 'unspecified')
  • Updates initial state, resetAllSettings, wallet import migration, the Theme screen UI, analytics/log labels, and the appearance change listener
  • Adds backward-compatible null handling at all read sites (Root.tsx, index.js, Theme.tsx) so existing users with null persisted in storage continue to get correct system-default behavior after upgrading
WhatsApp Image 2026-05-02 at 11 15 24 PM

@cmgustavo cmgustavo force-pushed the bug/reset-all-settings-03 branch 2 times, most recently from 3894575 to 5129f39 Compare May 6, 2026 14:34
@cmgustavo cmgustavo force-pushed the bug/reset-all-settings-03 branch from 5129f39 to db7d6d0 Compare May 6, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant