Skip to content

Conversation

@bitfaster
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Jun 29, 2025

Coverage Status

coverage: 98.986% (-0.03%) from 99.02%
when pulling 94e97fb on users/alexpeck/buildall
into 019070a on main.

@bitfaster bitfaster requested a review from Copilot June 29, 2025 03:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the existing separate OS jobs into a single parallelized matrix build, unifying steps and parameterizing test, coverage, and artifact uploads.

  • Introduces a matrix strategy to run multiple framework/OS combos in parallel
  • Consolidates test and artifact upload steps using matrix variables and a bash script
  • Parameterizes coveralls publishing and NuGet artifact upload per matrix entry
Comments suppressed due to low confidence (2)

.github/workflows/gate.yml:16

  • The continue-on-error key is only valid on steps, not at the job level. If you want the matrix to continue after a failure, replace this with strategy.fail-fast: false under strategy.
    continue-on-error: true

.github/workflows/gate.yml:112

  • The upload step for .NET Std runs only when matrix.std is true but lacks if: success() || failure(), so artifacts won’t be uploaded if tests fail. Add that condition to ensure results are always captured.
        if: ${{ matrix.std }}

@bitfaster bitfaster changed the title build in parallel parallelized matrix build Jun 29, 2025
@bitfaster bitfaster marked this pull request as ready for review June 30, 2025 19:02
@bitfaster bitfaster merged commit fa14abd into main Jun 30, 2025
16 checks passed
@bitfaster bitfaster deleted the users/alexpeck/buildall branch June 30, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants