Skip to content

make Data JSON-like, fix json matcher #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowp merged 1 commit into from
Feb 12, 2026
Merged

make Data JSON-like, fix json matcher #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/bitdrift_public/protobuf/logging/v1/payload.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,19 @@ message Data {
double double_data = 4;
int64 sint_data = 5;
bool bool_data = 6;
MapData map_data = 7;
ArrayData array_data = 8;
}
}

message MapData {
map<string, Data> entries = 1;
}

message ArrayData {
repeated Data items = 1;
}

enum LogType {
// Normal logs, from application code.
NORMAL = 0;
Expand Down
16 changes: 7 additions & 9 deletions src/bitdrift_public/protobuf/value_matcher/v1/value_matcher.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,16 @@ message SemVerValueMatch {

message JsonPathValueMatch {
Operator operator = 1 [(validate.rules).enum.defined_only = true];
message JsonPath {
message KeyOrIndex {
oneof key_or_index {
option (validate.required) = true;
message KeyOrIndex {
oneof key_or_index {
option (validate.required) = true;

string key = 1 [(validate.rules).string = {min_len: 1}];
int32 index = 2;
}
string key = 1 [(validate.rules).string = {min_len: 1}];
int32 index = 2;
}

string path = 1 [(validate.rules).string = {min_len: 1}];
}

repeated KeyOrIndex key_or_index = 3 [(validate.rules).repeated = {min_items: 1}];
string match_value = 2 [(validate.rules).string = {min_len: 1}];
}

Expand Down
Loading