qt: Copy txid by clicking bubbles in block view #225
Conversation
1440000bytes
commented
Oct 17, 2025
1440000bytes
commented
|
Hmm, seems like it would be better to open a transaction-view dialog with more information. Maybe a right-click menu with copy txid to clipboard (I think we have that elsewhere too?) |
I thought about this earlier but found it worse in UX. |
| const auto tx = gi ? gi->data(0).value<CTransactionRef>() : CTransactionRef(); | ||
| if (tx) { | ||
| QString txid = QString::fromStdString(tx->GetHash().ToString()); | ||
| QApplication::clipboard()->setText(txid); |
There was a problem hiding this comment.
Should use GUIUtil::setClipboard() instead of direct clipboard access using the helper in guiutil.cpp:904 since this current implementation doesn't support X11 Selection clipboard (the helper handles both modes)
For reference: transactionview.cpp:467 uses GUIUtil::copyEntryData() which calls setClipboard()
| #endif | ||
| QToolTip::showText(event_global_pos, tr("Copied: %1").arg(txid), this, {}, -1); | ||
|
|
||
| return; |
There was a problem hiding this comment.
This return skips QGraphicsView::mousePressEvent(event) (line 107) which could break panning/selection/other interactions when clicking on the transaction bubbles. Consider only returning if you don't want other mouse handling.
| return QGraphicsView::viewportEvent(event); | ||
| } | ||
|
|
||
| void ScalingGraphicsView::mousePressEvent(QMouseEvent * const event) |
There was a problem hiding this comment.
Left-click behavior is inconsistent with rest of the UI
- For reference,
transactionview.cpp:155uses right-click context menu: "Copy transaction &ID" - @luke-jr suggestion about existing UX patterns
- (right-click for actions, left-click for selection)
There was a problem hiding this comment.
We are not using bubbles anywhere else in the UI. It is a better UX to just click and copy the transaction id.
There was a problem hiding this comment.
Only thing is whether there is an indicator for the user to know this functionality exists (click and copy the transaction id).
| #else | ||
| const QPoint event_global_pos = event->globalPos(); | ||
| #endif | ||
| QToolTip::showText(event_global_pos, tr("Copied: %1").arg(txid), this, {}, -1); |
There was a problem hiding this comment.
What's the intended behavior for the -1 value? Permanent until mouse moves?
Consider using a timed duration (such as 2000ms) for better tooltip timeout UX.
There was a problem hiding this comment.
-1 is default and I tried other values from 2000 to 100000 but they didn't work as expected.
1440000bytes
force-pushed
the
blockview-txid
branch
from
3a176cb to
74508f6
Compare
3 participants
