add smooth open/close animations to mobile menu#4505
Open
ritorhymes wants to merge 1 commit intobitcoin-dot-org:masterfrom
Open
add smooth open/close animations to mobile menu#4505ritorhymes wants to merge 1 commit intobitcoin-dot-org:masterfrom
ritorhymes wants to merge 1 commit intobitcoin-dot-org:masterfrom
Conversation
…enus on mobile - Height transition based on measured scrollHeight - Link and language selector fade-in on expand - Collapse while submenu expanded temporarily forces dark bg/border to avoid color artifacts - Cleans up inline styles post-animation so CSS remains source of truth - Scoped to mobile-menu only; desktop not affected - Implemented as an IIFE to encapsulate helpers and avoid global-scope pollution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On mobile, when the menus open and close to reveal or hide items, it happens instantly without an animation. But because of the screen size, it's kind of jarring to see basically 1/3 of the screen instantaneously jump around when the user is trying to navigate. Here I add a utility module
mobile-animate-menu.jsthat smoothly animates the opening and closing of the hamburger menu and its submenus, affecting both thebaseandbase-coreversions. It doesn't require any new dependencies to run.It's a modular addition that works with a single import in
html-head.htmlwithout needing to edit, refactor or entangle itself in the base menu logic. It's implemented as an IIFE to encapsulate internal helpers and avoid global-scope pollution.Behaviors
Demo
bitcoin-menu-demo.mp4