Skip to content

fix token duration #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pinheadmz merged 1 commit into from
Feb 28, 2026
Merged

fix token duration #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/warnet/k8s.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
V1Namespace,
V1Pod,
V1PodList,
V1TokenRequestSpec,
)
from kubernetes.client.rest import ApiException
from kubernetes.dynamic import DynamicClient
Expand Down Expand Up @@ -574,14 +573,15 @@ def get_warnet_user_service_accounts_in_namespace(namespace):


def get_token_for_service_acount(sa, duration):
sclient = get_static_client()
spec = V1TokenRequestSpec(
audiences=["https://kubernetes.default.svc"], expiration_seconds=duration
)
resp = sclient.create_namespaced_service_account_token(
name=sa.metadata.name, namespace=sa.metadata.namespace, body=spec
# # The Kubernetes Python client’s TokenRequest calls were routed through
# # DigitalOcean’s konnectivity path, which overrides the requested audience
# # and enforces a 1-hour max expiration. `kubectl create token` uses a
# # different control-plane path that preserves the default API audience and allows longer durations.
# # `sclient.create_namespaced_service_account_token()` will NOT work :-(
command = (
f"kubectl create token {sa.metadata.name} -n {sa.metadata.namespace} --duration={duration}s"
)
return resp.status.token
return run_command(command)


def can_delete_pods(namespace: Optional[str] = None) -> bool:
Expand Down