Skip to content

Conversation

@darosior
Copy link
Member

@darosior darosior commented Oct 6, 2025

In #1147 we added examples for each severity level. While this is useful to have as an illustration in the policy, this made the first part of the "Policy" section take a lot more space. It takes almost 1.5x the height of my high resolution office monitor. This means scrolling up more than one entire page before getting to the disclosure timeline, let alone the latest publish advisories.

This PR reduces the prominence of the severity level by reducing the size of the section titles and by putting the example under a collapsible section.

Here is how it changes the display for me.

Before:
image

After:
image

The examples are useful to have but should be less prominent than the latest
published advisories, or the security disclosure policy timeline.
@darosior
Copy link
Member Author

darosior commented Oct 6, 2025

I feel like we could almost get back to bullet points for each severity level. It's a bit contrived, but i feel like the flow makes more sense this way. Let me know what you think.

image image

@janb84
Copy link

janb84 commented Oct 6, 2025

I would opt for the bullet points style for increased readability. less scrolling and better overview over the different levels.

These are part of the paragraph but appeared to be almost a new section of
their own. This also reduces the scroll necessary to get to the latest
published security advisories.
@darosior darosior force-pushed the 2510_cleanup_advisories_page branch from aaca4c8 to 0e8f0c8 Compare October 6, 2025 19:18
@darosior
Copy link
Member Author

darosior commented Oct 6, 2025

Ok, i agree. I have a slight preference for the bullet points list too. Pushed a commit that does that instead. Old version is still visible as a screenshot in OP.

Copy link

@janb84 janb84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e8f0c8

PR introduces bullet points for the severity headers and collapsible section for the examples. This makes the page more readable and creates a more unified severity section, with the different levels displayed together.

  • code review ✅

@achow101
Copy link
Member

ACK 0e8f0c8

@achow101 achow101 merged commit 7c34ca7 into bitcoin-core:master Oct 10, 2025
2 checks passed
azuchi added a commit to azuchi/bitcoincore.org that referenced this pull request Oct 15, 2025
fanquake added a commit that referenced this pull request Oct 15, 2025
8d652da Apply #1178 to japanese translation (azuchi)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 43430a08913c3a48190b3e5ff763ead739b8d315c45834ad49c57c7ff92636ac8294d5332aeed0bdcd790ad79cd40df91d6c4604e9ae62bc0c6af3ff7c46fb61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants