multi: post client account id with bonds.#8
Closed
dnldd wants to merge 1 commit intobisoncraft:masterfrom
Closed
Conversation
This updates the bonds posting process to provide the account id of the client since the provided bonds will be validated against the client's provided identity.
dnldd
force-pushed
the
client_account_id
branch
from
b3c3061 to
09f6721
Compare
martonp
reviewed
Feb 11, 2026
Contributor
martonp
left a comment
martonp
left a comment
There was a problem hiding this comment.
Shouldn't the accountID just be the libp2p node ID?
Contributor
Author
It can be but that would be relying on the libp2p's standard which could change instead of enforcing our own. This BLAKE256 hash of the public key is what dcrdex uses for bonds currently. Makes sense to continue with it. |
Contributor
|
You don't need to send the hash to the tatanka node. The tatanka node can call |
Contributor
Author
|
noted, will make the adjustments. |
Contributor
Author
|
Closing this. will make the suggested change on the bond verifier PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the bonds posting process to provide the account id of the client since the provided bonds will be validated against the client's provided identity.