Skip to content

Conversation

@jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Aug 12, 2025

close #56

  • this is slightly less opinionated than our internal lab template, ideally lowering the number of nitpicks that a volunteer community member might have to step over to get a PR merged
  • I might make 1-2 final tweaks as I get through the end of the HGVS codebase, but I'm putting this up for review now because I think it's close enough

@jsstevenson jsstevenson marked this pull request as ready for review August 23, 2025 20:23
@jsstevenson jsstevenson requested a review from a team as a code owner August 23, 2025 20:23
korikuzma
korikuzma previously approved these changes Aug 25, 2025
@reece
Copy link
Member

reece commented Aug 26, 2025

@jsstevenson I can't tell what's supposed to happen with this PR and the failing tests. Can you please clarify?

@korikuzma
Copy link
Contributor

@reece Branch just needed to be updated. Tests are passing

@jsstevenson
Copy link
Contributor Author

Ah, thanks @korikuzma. @reece this was an issue relating to the pytest-optional-dependencies library -- something about the build/release for that package was broken, causing pytest runs to fail (regardless of whether the package was even used). This was creating failures in this repo as well as bioutils and seqrepo. I think we have now pushed out fixes to all affected repos.

@jsstevenson
Copy link
Contributor Author

Ok, I need to update to handle this week's changes and then I can put back up. I have implementation PRs up on bioutils, seqrepo, and anyvar.

@jsstevenson
Copy link
Contributor Author

redoing in #72

@jsstevenson jsstevenson closed this Sep 2, 2025
jsstevenson added a commit to biocommons/anyvar that referenced this pull request Sep 11, 2025
Add biocommons template updates -- see
biocommons/python-package#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update linting/formatting/etc

4 participants