Standardize dark mode rendering for injected tables#52
Open
AdityaBVerma wants to merge 1 commit intobinbard:mainfrom
Open
Standardize dark mode rendering for injected tables#52AdityaBVerma wants to merge 1 commit intobinbard:mainfrom
AdityaBVerma wants to merge 1 commit intobinbard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I initially fixed a dark mode visibility issue on the Friends page. While testing further, I noticed the same issue affecting other injected tables, so this PR extends the fix for consistency.
Summary
In dark mode, some injected tables retained light backgrounds while text switched to light colors, causing low contrast. This PR standardizes dark mode handling by adding defensive dark backgrounds and ensuring injected Friends rows correctly activate
dark:styles.Before
###After
Areas Fixed
Testing