Add PXD000084 honeybee caste/organ proteome SDRF - #495
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review by Qodo
1. Unverified files enter the canonical dataset
|
| Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx0 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 0 1 QWT401A_brain_scx0.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available | ||
| Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx1 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 1 1 QWT401A_brain_scx1.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available | ||
| Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx2 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 2 1 QWT401A_brain_scx2.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available | ||
| Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx3 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 3 1 QWT401A_brain_scx3.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available |
There was a problem hiding this comment.
1. Unverified files enter the canonical dataset 📘 Rule violation ≡ Correctness
The SDRF adds rows 28–39 for QWT401A_* raw files and assigns brain metadata, ontology terms, and replicate relationships even though their archive-to-sample mappings were not established. Because the PR explicitly defers all QWT401* files, downstream users may treat these unsupported assignments as authoritative and the published subset as consistent with evidence-backed curation.
Agent Prompt
## Issue description
The canonical SDRF includes twelve `QWT401A_*` files even though the PR scope says all `QWT401*` files were deliberately deferred because their archive-to-organ mappings could not be established. Their brain annotations, ontology terms, replicate relationships, and sample mappings are therefore unsupported and make the curated subset inconsistent with its stated inclusion criteria.
## Fix Focus Areas
- datasets/PXD000084/PXD000084.sdrf.tsv[28-39]
## Recommended Fix
Remove the twelve `QWT401A_*` rows from the canonical SDRF, or, if they are intentionally included, update the dataset scope and provide authoritative archive or public-evidence support for every asserted file, organ, sample, replicate, and relationship. Keep only files whose metadata can be traced to the stated curation evidence.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
PR Summary by QodoAdd PXD000084 honeybee proteomics SDRF
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Summary
datasets/PXD000084/PXD000084.sdrf.tsv: 38 label-free runs for Apis mellifera ligustica (honeybee), covering brain, crop, and midgut samples across castes (drone, worker, queen) — filename-mapped subset of the deposited archive (PMID 23878156).QWT401*and others) are deliberately deferred — MaxQuant experiment-letter codes could not be mapped to organs from PRIDE metadata, the paper, or the PeptideAtlas build XML.croporgan part uses UBERON:0007356 (OLS preferred term).comment[label]is kept as label-free for the included subset; the dataset also has dimethyl-labeled comparisons whose channel-to-file mapping wasn't recoverable — documented as a limitation, not asserted.Validation
parse_sdrf validate-sdrf --use_ols_cache_onlypasses forms-proteomicsandinvertebrates(only a repo-wide PRIDE:0000627 parent-cache warning and an unverifiable-without-live-lookup instrument label warning)..github/scripts/sdrf_review.pygate: 1/1 clean — required a fix to use bare ontology labels (notNT=;AC=) incharacteristics[*]columns, per the gate's current rule; the file predated that convention.Test plan
validate/reviewchecks pass