Skip to content

Add PXD000084 honeybee caste/organ proteome SDRF - #495

Open
ypriverol wants to merge 1 commit into
mainfrom
pxd000084-honeybee
Open

Add PXD000084 honeybee caste/organ proteome SDRF#495
ypriverol wants to merge 1 commit into
mainfrom
pxd000084-honeybee

Conversation

@ypriverol

Copy link
Copy Markdown
Contributor

Summary

  • Adds datasets/PXD000084/PXD000084.sdrf.tsv: 38 label-free runs for Apis mellifera ligustica (honeybee), covering brain, crop, and midgut samples across castes (drone, worker, queen) — filename-mapped subset of the deposited archive (PMID 23878156).
  • 534 additional RAW files (QWT401* and others) are deliberately deferred — MaxQuant experiment-letter codes could not be mapped to organs from PRIDE metadata, the paper, or the PeptideAtlas build XML.
  • crop organ part uses UBERON:0007356 (OLS preferred term).
  • comment[label] is kept as label-free for the included subset; the dataset also has dimethyl-labeled comparisons whose channel-to-file mapping wasn't recoverable — documented as a limitation, not asserted.
  • Independent adversarial review already recorded a PASS verdict for this file (spec compliance, evidence traceability, no blocking/important issues).

Validation

  • parse_sdrf validate-sdrf --use_ols_cache_only passes for ms-proteomics and invertebrates (only a repo-wide PRIDE:0000627 parent-cache warning and an unverifiable-without-live-lookup instrument label warning).
  • Repo's .github/scripts/sdrf_review.py gate: 1/1 clean — required a fix to use bare ontology labels (not NT=;AC=) in characteristics[*] columns, per the gate's current rule; the file predated that convention.

Test plan

  • CI validate / review checks pass

Copilot AI balanced review requested due to automatic review settings September 14, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • datasets/PXD000084/PXD000084.sdrf.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9b3855c4-3450-4f15-b9d2-906eecade9d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📜 Skill insights (0)

Grey Divider


Action required

1. Unverified files enter the canonical dataset 📘 Rule violation ≡ Correctness
Description
The SDRF adds rows 28–39 for QWT401A_* raw files and assigns brain metadata, ontology terms, and
replicate relationships even though their archive-to-sample mappings were not established. Because
the PR explicitly defers all QWT401* files, downstream users may treat these unsupported
assignments as authoritative and the published subset as consistent with evidence-backed curation.
Code

datasets/PXD000084/PXD000084.sdrf.tsv[R28-31]

+Am_not_available_brain	Apis mellifera ligustica	brain	not applicable	normal	adult	not available	not available	not available	not available	tissue	1	QWT401A_brain_scx0	proteomic profiling by mass spectrometry	NT=Data-dependent acquisition;AC=PRIDE:0000627	NT=LTQ Orbitrap;AC=MS:1000447	NT=label free sample;AC=MS:1002038	NT=Trypsin;AC=MS:1001251	NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable	NT=collision-induced dissociation;AC=MS:1000133	NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561	20 ppm	0.5 Da	0	1	QWT401A_brain_scx0.RAW	v1.1.0	manual curation	NT=invertebrates;VV=v1.1.0	NT=brain;AC=UBERON:0000955	not available
+Am_not_available_brain	Apis mellifera ligustica	brain	not applicable	normal	adult	not available	not available	not available	not available	tissue	1	QWT401A_brain_scx1	proteomic profiling by mass spectrometry	NT=Data-dependent acquisition;AC=PRIDE:0000627	NT=LTQ Orbitrap;AC=MS:1000447	NT=label free sample;AC=MS:1002038	NT=Trypsin;AC=MS:1001251	NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable	NT=collision-induced dissociation;AC=MS:1000133	NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561	20 ppm	0.5 Da	1	1	QWT401A_brain_scx1.RAW	v1.1.0	manual curation	NT=invertebrates;VV=v1.1.0	NT=brain;AC=UBERON:0000955	not available
+Am_not_available_brain	Apis mellifera ligustica	brain	not applicable	normal	adult	not available	not available	not available	not available	tissue	1	QWT401A_brain_scx2	proteomic profiling by mass spectrometry	NT=Data-dependent acquisition;AC=PRIDE:0000627	NT=LTQ Orbitrap;AC=MS:1000447	NT=label free sample;AC=MS:1002038	NT=Trypsin;AC=MS:1001251	NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable	NT=collision-induced dissociation;AC=MS:1000133	NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561	20 ppm	0.5 Da	2	1	QWT401A_brain_scx2.RAW	v1.1.0	manual curation	NT=invertebrates;VV=v1.1.0	NT=brain;AC=UBERON:0000955	not available
+Am_not_available_brain	Apis mellifera ligustica	brain	not applicable	normal	adult	not available	not available	not available	not available	tissue	1	QWT401A_brain_scx3	proteomic profiling by mass spectrometry	NT=Data-dependent acquisition;AC=PRIDE:0000627	NT=LTQ Orbitrap;AC=MS:1000447	NT=label free sample;AC=MS:1002038	NT=Trypsin;AC=MS:1001251	NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable	NT=collision-induced dissociation;AC=MS:1000133	NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561	20 ppm	0.5 Da	3	1	QWT401A_brain_scx3.RAW	v1.1.0	manual curation	NT=invertebrates;VV=v1.1.0	NT=brain;AC=UBERON:0000955	not available
Evidence
Rows 28–39 contain twelve QWT401A data-file entries, and each assigns brain and UBERON:0000955
along with replicate information. The PR description identifies the QWT401* files as deliberately
deferred because their organ mappings could not be recovered, so these entries conflict with the
stated scope and required evidence-backed archive and sample mappings.

AGENTS.md: Align SDRF Annotations with Archive Metadata and Public Evidence
datasets/PXD000084/PXD000084.sdrf.tsv[28-39]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The canonical SDRF includes twelve `QWT401A_*` files even though the PR scope says all `QWT401*` files were deliberately deferred because their archive-to-organ mappings could not be established. Their brain annotations, ontology terms, replicate relationships, and sample mappings are therefore unsupported and make the curated subset inconsistent with its stated inclusion criteria.

## Fix Focus Areas
- datasets/PXD000084/PXD000084.sdrf.tsv[28-39]

## Recommended Fix
Remove the twelve `QWT401A_*` rows from the canonical SDRF, or, if they are intentionally included, update the dataset scope and provide authoritative archive or public-evidence support for every asserted file, organ, sample, replicate, and relationship. Keep only files whose metadata can be traced to the stated curation evidence.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
Review mode: 🚀 Fast: This is a single, self-contained SDRF data addition with no runtime logic or high-risk behavior, and its validation is already documented as passing.

Grey Divider

Tip of the day
💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment on lines +28 to +31
Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx0 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 0 1 QWT401A_brain_scx0.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available
Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx1 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 1 1 QWT401A_brain_scx1.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available
Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx2 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 2 1 QWT401A_brain_scx2.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available
Am_not_available_brain Apis mellifera ligustica brain not applicable normal adult not available not available not available not available tissue 1 QWT401A_brain_scx3 proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=LTQ Orbitrap;AC=MS:1000447 NT=label free sample;AC=MS:1002038 NT=Trypsin;AC=MS:1001251 NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable NT=collision-induced dissociation;AC=MS:1000133 NT=Strong cation-exchange chromatography (SCX);AC=PRIDE:0000561 20 ppm 0.5 Da 3 1 QWT401A_brain_scx3.RAW v1.1.0 manual curation NT=invertebrates;VV=v1.1.0 NT=brain;AC=UBERON:0000955 not available

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Unverified files enter the canonical dataset 📘 Rule violation ≡ Correctness

The SDRF adds rows 28–39 for QWT401A_* raw files and assigns brain metadata, ontology terms, and
replicate relationships even though their archive-to-sample mappings were not established. Because
the PR explicitly defers all QWT401* files, downstream users may treat these unsupported
assignments as authoritative and the published subset as consistent with evidence-backed curation.
Agent Prompt
## Issue description
The canonical SDRF includes twelve `QWT401A_*` files even though the PR scope says all `QWT401*` files were deliberately deferred because their archive-to-organ mappings could not be established. Their brain annotations, ontology terms, replicate relationships, and sample mappings are therefore unsupported and make the curated subset inconsistent with its stated inclusion criteria.

## Fix Focus Areas
- datasets/PXD000084/PXD000084.sdrf.tsv[28-39]

## Recommended Fix
Remove the twelve `QWT401A_*` rows from the canonical SDRF, or, if they are intentionally included, update the dataset scope and provide authoritative archive or public-evidence support for every asserted file, organ, sample, replicate, and relationship. Keep only files whose metadata can be traced to the stated curation evidence.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add PXD000084 honeybee proteomics SDRF

✨ Enhancement 🕐 20-40 Minutes

Grey Divider

AI Description

• Adds an SDRF for 38 evidence-mapped PXD000084 honeybee proteomics runs.
• Annotates organ, caste, replicate, fractionation, acquisition, and RAW-file metadata.
• Limits coverage to runs with defensible filename-to-sample mappings.
Diagram

graph TD
  A["Public Evidence"] -->|supports mapping| B["38 RAW Runs"] -->|described by| C["PXD000084 SDRF"] -->|checked by| D["SDRF Validation"]
  E["Sample Factors"] -->|annotate| C
  F["Ontology Terms"] -->|standardize| C
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Annotate the complete archive
  • ➕ Provides an inventory for every deposited RAW file
  • ➕ Avoids requiring later accession-level expansion
  • ➖ Unresolved organ and experiment-code mappings would reduce metadata reliability
  • ➖ Label-free and dimethyl experiments could be conflated without defensible channel mappings
2. Split experiment families into separate SDRFs
  • ➕ Keeps label-free and dimethyl workflows clearly isolated
  • ➕ Allows each experiment family to expand independently
  • ➖ Still requires evidence resolving deferred file and channel mappings
  • ➖ Creates additional files and maintenance overhead for one accession

Recommendation: Retain the evidence-limited SDRF as the safest current approach. It follows the repository rule against inferred sample relationships while providing immediately usable metadata; deferred experiment families should be added only when public evidence supports their organ and labeling mappings.

Files changed (1) +39 / -0

Enhancement (1) +39 / -0
PXD000084.sdrf.tsvAdd curated SDRF metadata for 38 PXD000084 honeybee assays +39/-0

Add curated SDRF metadata for 38 PXD000084 honeybee assays

• Introduces 38 label-free DDA assays from Apis mellifera ligustica, covering confidently mapped brain and crop samples with drone, queen, or unavailable caste metadata. It records RAW-file relationships, biological and technical replicates, SCX fractions, LTQ Orbitrap acquisition parameters, and controlled anatomy and proteomics terms.

datasets/PXD000084/PXD000084.sdrf.tsv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants