Add SDRF annotations for 46 small label-free PRIDE datasets - #485
Conversation
These accessions were previously unannotated, have fewer than ten RAW files, and passed parse_sdrf plus independent adversarial review. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoAnnotate eight small label-free PRIDE datasets with SDRF metadata
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
1. Pancreatic groups become genetic changes
|
| PDAC_SI-NC Homo sapiens pancreas pancreatic ductal cell pancreatic ductal adenocarcinoma cell line SI-NC not available not available not available 1 R15034-22-SI-NC proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=label free sample;AC=MS:1002038 NT=Q Exactive;AC=MS:1001911 NT=Trypsin/P;AC=MS:1001313 NT=Carbamidomethyl;AC=UNIMOD:4;TA=C;MT=Fixed NT=Oxidation;AC=UNIMOD:35;TA=M;MT=Variable NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable 6 ppm 20 ppm 1 1 R15034-22-SI-NC.raw v1.1.0 NT=ms-proteomics;VV=v1.1.0 NT=human;VV=v1.1.0 manual curation SI-NC | ||
| PDAC_SI-H Homo sapiens pancreas pancreatic ductal cell pancreatic ductal adenocarcinoma cell line SI-H not available not available not available 1 R15034-22-SI-H proteomic profiling by mass spectrometry NT=Data-dependent acquisition;AC=PRIDE:0000627 NT=label free sample;AC=MS:1002038 NT=Q Exactive;AC=MS:1001911 NT=Trypsin/P;AC=MS:1001313 NT=Carbamidomethyl;AC=UNIMOD:4;TA=C;MT=Fixed NT=Oxidation;AC=UNIMOD:35;TA=M;MT=Variable NT=Acetyl;AC=UNIMOD:1;PP=Protein N-term;MT=Variable 6 ppm 20 ppm 1 1 R15034-22-SI-H.raw v1.1.0 NT=ms-proteomics;VV=v1.1.0 NT=human;VV=v1.1.0 manual curation SI-H |
There was a problem hiding this comment.
2. Pancreatic groups become genetic changes 📘 Rule violation ≡ Correctness
PXD017452.sdrf.tsv puts SI-NC and SI-H in both characteristics[genetic modification] and factor value[genetic modification], although those strings only reproduce source and archive file-name tokens. With no identified modification or supporting project evidence, downstream comparisons interpret two opaque groups as genetic modifications rather than file-derived group labels.
Agent Prompt
## Issue description
The PXD017452 annotation presents the opaque filename tokens `SI-NC` and `SI-H` as identified genetic modifications even though no modification identity is available.
## Fix Focus Areas
- datasets/PXD017452/PXD017452.sdrf.tsv[1-3]
## Recommended Fix
Set the unknown genetic-modification characteristic to `not available` and move `SI-NC` and `SI-H` to a neutral, explicitly file-derived grouping factor. Preserve the existing source and data-file mappings without inferring a knockdown target or other biological mechanism.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The PR review script rejects NT=/AC= encoding on characteristics; comments and factor values are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
Day-4 mCherry+ organoid cells are annotated as embryo stage; cell type is not available because the paper places them between eye field and early RPC. Co-authored-by: Cursor <cursoragent@cursor.com>
Methods give that mixed mES background for the parental Crx-GFP line used to derive the reporter organoids. Co-authored-by: Cursor <cursoragent@cursor.com>
Wave 2 covers PXD062082, PXD063885, PXD013508, and PXD014033 with RAW-header instruments and filename-true factors. Co-authored-by: Cursor <cursoragent@cursor.com>
Independent review passed for bovine, Xenopus, mouse, chickpea, bacteria, virus, snake, horse, and dinoflagellate deposits with two to four uncompressed .raw files. Co-authored-by: Cursor <cursoragent@cursor.com>
Skip five still-pending accessions (PXD013419, PXD037732, PXD045506, PXD047367, PXD050355) until they clear adversarial review. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
<10RAW files each) underdatasets/{PXD}/{PXD}.sdrf.tsv.review_gate.py gateclean).parse_sdrf validate-sdrf --use_ols_cache_onlyis warnings-only (typicalPRIDE:0000627parent-cache warning).Datasets and public evidence
SI-NC/SI-H)Annotation notes for reviewers
normal; 15-daynot available(hypertrophy vs atrophy conflict); 60-day muscular atrophy.SI-NC/SI-Hrather than inferred knockdown labels (no paper).UBERON:0003071), not retina, for day-4 eye-field FACS cells.not available(PRIDE lists brain; files are unlabeled).Test plan
parse_sdrf validate-sdrfon changed.sdrf.tsvfilesMade with Cursor