Skip to content

docs: follow up on #826 review items - #829

Merged
ypriverol merged 4 commits into
bigbio:devfrom
ypriverol:codex/followup-review-826
Apr 28, 2026
Merged

docs: follow up on #826 review items#829
ypriverol merged 4 commits into
bigbio:devfrom
ypriverol:codex/followup-review-826

Conversation

@ypriverol

@ypriverol ypriverol commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • register characteristics[tissue supergroup] as an optional shared sample metadata field in the spec terms registry
  • restore and align the organism part / tissue supergroup / sampling site guidance in the sample documentation
  • add the missing changelog entries for the organism-part clarification and the metabolomics example SDRFs
  • declare comment[sdrf template] values in the PXD073289 AB Sciex example so CI detects dia-acquisition
  • clarify that a single canonical archive such as .raw.zip can already be recorded directly in comment[data file]

Context

These are the immediate follow-up fixes identified during the review of #826 after the release-style merge landed on master. The original review called out tissue supergroup as a forward reference; this PR now formalizes it instead of dropping it.

Validation

  • parse_sdrf validate-sdrf --sdrf_file examples/PXD073289/PXD073289.sdrf.tsv --template dia-acquisition --use_ols_cache_only
  • git diff --check

Add re-annotated metabolomics SDRFs for lc-ms validation
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@ypriverol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 43 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ea679d3-3e8f-4705-b082-dcb30e32cbb6

📥 Commits

Reviewing files that changed from the base of the PR and between 6c440f7 and 180751e.

⛔ Files ignored due to path filters (2)
  • examples/PXD073289/PXD073289.sdrf.tsv is excluded by !**/*.tsv
  • sdrf-proteomics/TERMS.tsv is excluded by !**/*.tsv
📒 Files selected for processing (3)
  • CHANGELOG.md
  • psi-document/v1.1.0-dev/supplementary-files/sample-metadata-v1.1.0-dev.adoc
  • sdrf-proteomics/README.adoc
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

codacy-production Bot commented Apr 28, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ypriverol
ypriverol changed the base branch from master to dev April 28, 2026 14:58
@ypriverol
ypriverol merged commit bfd79ac into bigbio:dev Apr 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant