Repository navigation
Send the Authorization header only when PEERINGDB_API_KEY is set - #2
Merged
Merged
Conversation
Merged
digizeph
approved these changes
Aug 2, 2026
digizeph
left a comment
digizeph
left a comment
Member
There was a problem hiding this comment.
Review (via Hermes Agent)
Verified the bug and the fix against the live API: with the old code the empty Authorization: Api-Key header gets a hard 400 Bad Request from PeeringDB; with the header omitted (this PR) the API answers and only rate-limits (429) without a key, as the warning says. The Ok(key) if !key.is_empty() guard also handles an empty env var. fmt/clippy clean locally, CI build passed. LGTM.
Note: PR #3 branched from pre-fix main still contains the unconditional empty auth header in its get_reader_with_params refactor — rebase it on this to avoid reverting the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
PEERINGDB_API_KEYis unset,get_readersendsAuthorization: Api-Keywith an empty key, which PeeringDB rejects with HTTP 400{"error": "Unknown authorization method"}.This means that keyless calls currently always fail. Omitting the header entirely makes anonymous requests work (subject to anonymous rate limits). The existing warning is kept.
Cheers