fix: harden upgrade and hook checks#188
Open
bestdan wants to merge 7 commits into
Open
Conversation
## Summary - **Fix 6 TypeScript errors** in `codeowners/check.ts` and `graphql/check.ts`: Add explicit null guards after `ensureCondition()` calls (which call `process.exit` but don't narrow types), and add undefined checks for regex match destructuring of `state`/`rawPath` - **Fix Prettier formatting** in 3 files: line length violations in `codeowners/check.ts`, `graphql/check.ts`, and `upgrade.test.ts` ## Test plan - [x] `pnpm typecheck` passes (0 errors) - [x] `pnpm lint` passes (ESLint + Prettier) - [x] `pnpm format:check` passes Supersedes #189 (rebased onto correct base branch). https://claude.ai/code/session_01RobTdhpRAXuPkyQ8CknbWd
…bilities Fix TS2345/TS18048 errors by adding null guards before getNewlyChangedFiles calls in codeowners and graphql check commands. Update @typescript-eslint (8.46→8.57), vitest (4.0→4.1), and add pnpm overrides for picomatch and brace-expansion to resolve all audit findings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lify graphql suffixes - Extract duplicated parseGitStatusEntries/getNewlyChangedFiles into src/utils/git-status.ts - Add isValidGitRef validation for the ref parameter in upgradeFromGitHub - Simplify GRAPHQL_GENERATED_SUFFIXES to use literal values instead of filtering - Export new git-status utilities from src/index.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.