fix: align Docker working directory with reth for relative path compatibility#28
Merged
Conversation
- Update chainspec import to use alloy::evm instead of alloy_evm - Add missing timestamp parameter to next_block_base_fee calls - Remove unused dependencies: log, reth-node-api, reth-rpc, reth-trie-db - Update Cargo.lock with cargo update to resolve version conflicts
…tibility - Remove WORKDIR /app to match standard reth Docker configuration - Fixes relative path resolution in containerized environments - Resolves issue where .tmp/file.json would resolve to /app/.tmp/file.json instead of /.tmp/file.json Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKDIR /appto match reth's Docker configuration where working directory defaults to/.tmp/genesis.jsonwould incorrectly resolve to/app/.tmp/genesis.jsoninstead of/.tmp/genesis.jsonProblem
The issue occurred because:
WORKDIR /app/)-v $(pwd)/.tmp:/.tmp, the relative path.tmp/file.jsonresolves differently:.tmp/file.json→/.tmp/file.json✅.tmp/file.json→/app/.tmp/file.json❌Solution
Remove the
WORKDIR /appline from Dockerfile to match reth's behavior exactly.Test Plan
-w /override successfullyWORKDIR /applineCloses #27