Enhance metadata from original sources if possible#500
Open
stufisher wants to merge 5 commits intobencevans:masterfrom
Open
Enhance metadata from original sources if possible#500stufisher wants to merge 5 commits intobencevans:masterfrom
stufisher wants to merge 5 commits intobencevans:masterfrom
Conversation
4 tasks
Collaborator
|
I like the idea to do this, why isn't sonos doing this by itself? Apart from that, this seems like something that is perfectly testable. Can you create a test for loading the info for some random soundcloud track? And I see that it’s no longer possible to create a client Id for SoundCloud, but do you really need a separate library just to scrape the client id? A regular expression would be sufficient I guess? how does this relate to accessing the external music service data directly, like described here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to isolate the interaction with other services. Enhanced metadata can be enabled by setting
ENHANCE_METADATA=truein your env. Works for currently playing and things in the queue.Some feedback on this would be useful, there are likely things i dont understand about how album art urls are generated, maybe there is a way to dynamically retrieve the radio art url?