Skip to content

fix: fix frame pointer manipulation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix frame pointer manipulation #62

wants to merge 1 commit into from

Conversation

@rosshjb
Copy link
Contributor

@rosshjb rosshjb commented Nov 5, 2024 •
edited
Loading

Two changes were made:

  1. In the original code, frame pointer FP is changed to point to SP, but it doesn't be restored to original value in the end — the FP is a callee-saved register. So, we should save an existing FP value and restore the value later.
  2. The FP points to top of stack frame. So the FP should refer the variables inside the frame with non-negative offset.

neldredge added a commit to neldredge/HelloSilicon that referenced this pull request Mar 25, 2025
@neldredge
Update README.md
b9f14d8 
Remove incorrect comment about `LSL X1, X2, below#1` being an alias for `ORR X1, XZR, X2, LSL below#1`.  Per the Architecture Reference Manual, it is instead an alias for `UBFM X1, X2, below#63, below#62`.  (Of course they have the same effect.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rosshjb