Skip to content

feat: added support for ignoring using directives#1877

Merged
belav merged 2 commits into
belav:mainfrom
TimothyMakkison:ignore_usings
Jun 20, 2026
Merged

feat: added support for ignoring using directives#1877
belav merged 2 commits into
belav:mainfrom
TimothyMakkison:ignore_usings

Conversation

@TimothyMakkison

@TimothyMakkison TimothyMakkison commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Added support for using ranged ignores in using directives solving #1856

  • The logic is pretty messy, but it seems to play well with #if directives
  • This does not support ranged ignores which bridge the usings section and the code
    • This might be an easy addition by adding a field to PrintingContext

@TimothyMakkison TimothyMakkison marked this pull request as draft June 14, 2026 00:02
@TimothyMakkison TimothyMakkison marked this pull request as ready for review June 19, 2026 22:04

@belav belav left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not support ranged ignores which bridge the usings section and the code

I believe that limitation exists almost everywhere. I assume it will get pretty messy to make sure it works everywhere and I don't know that it is worth it.

Thanks for getting this figured out!

@belav belav merged commit 04fbaeb into belav:main Jun 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants