Introduce compile_as_first and compile_as_array helpers #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 88.68% 88.78% +0.09%
==========================================
Files 27 27
Lines 3624 3656 +32
==========================================
+ Hits 3214 3246 +32
Misses 410 410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruscoder
reviewed
Oct 3, 2025
Pipfile
Outdated
| [packages] | ||
| antlr4-python3-runtime = "~=4.10" | ||
| python-dateutil = "~=2.8" | ||
| fhirpy-types-r4b = "==0.1.1" |
There was a problem hiding this comment.
move to dev deps if it's not direct dependency
ruscoder
reviewed
Oct 3, 2025
fhirpathpy/__init__.py
Outdated
|
|
||
| def compile_as_array( | ||
| expression: str, input_type: Type, output_type: Type | ||
| ) -> Callable[[Any], Any]: |
ruscoder
reviewed
Oct 3, 2025
fhirpathpy/__init__.py
Outdated
|
|
||
| def compile_as_first( | ||
| expression: str, input_type: Type, output_type: Type | ||
| ) -> Callable[[Any], Any]: |
…y` to use `TypeVar` for better type safety and adjust related helper functions Ref: #64
… helper functions to align with `InputType` and `OutputType`. Ref: #64
… update Pipfile.lock to reflect changes Ref: #64
…pes (e.g., `CustomModel`) Ref: #64
…d readability and consistency. #63
…zing type checks and exception handling Ref: #63
…ion via `prepare_fhirpath_fn` helper function. Ref: #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.