fix: return JSON error for extension endpoint exceptions - #2321
Open
pike00 wants to merge 2 commits into
Open
Conversation
added 2 commits
July 26, 2026 20:19
Previously an exception in an extension endpoint bubbled up to Flask's default HTML 500 page, making it hard for extension UIs to show a friendly message. Wrap endpoint handler calls and return a JSON object with error details.
Previously an exception in an extension endpoint bubbled up to Flask's default HTML 500 page, making it hard for extension UIs to show a friendly message. Wrap endpoint handler calls and return a JSON object with error details. - Catch Exception in extension_endpoint route, log with log.exception, return JSON with error/extension/endpoint keys and 500 status - Add example_error endpoint to FavaExtTest for testing - Add test_load_extension_endpoint_error test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously an exception in an extension endpoint bubbled up to Flask's default HTML 500 page, making it hard for extension UIs to show a friendly message. Wrap endpoint handler calls and return a JSON object with error details.
This is a small, focused change that makes the extension system more usable for JS-heavy extensions (like those using Preact/htm) that can't easily parse an HTML error page.