-
Notifications
You must be signed in to change notification settings - Fork 96
Remove broken gh-pages submodule #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yeah, it looks like this used when generating documentation web pages, here |
|
@myeatman-bdai Does that actually require the pseudo-submodule, though? Won't that command create the directory if missing? |
|
(or, if not, we could add a |
|
I don't know much about won't work. |
|
Shouldn't spatialmath-python/.github/workflows/sphinx.yml Lines 32 to 33 in 99fd55b
mkdir line before those two) make it work?
|
|
oh, you're right. Derp. |
|
Lets just merge this and see if the documentation generation still works. |
myeatman-bdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Per this yet to be merged PR #162, the sphinx automation is broken with or without this small changes, so we're going ahead and merging. |
This PR removes the
gh-pagesdirectory, which appears to have been set up as a submodule, but has no definition in a.gitmodulesfile (as no such file is present). This misconfiguration causes problems addingspatialmath-pythonas a dependency to other projects usinguv. If I'm wrong aboutgh-pagesbeing necessary to keep around (e.g., if it somehow triggers the creation of a Github Page for the project?), then we'll need to find a different solution.