Skip to content

PRIME-2735 Admin can edit HA Care Type Vendor mapping#2518

Open
bergomi02 wants to merge 16 commits into
developfrom
feature/prime-2735_ha_care_type_vendor_page
Open

PRIME-2735 Admin can edit HA Care Type Vendor mapping#2518
bergomi02 wants to merge 16 commits into
developfrom
feature/prime-2735_ha_care_type_vendor_page

Conversation

@bergomi02

Copy link
Copy Markdown
Collaborator

No description provided.

@bergomi02 bergomi02 added Frontend Updates to the frontend of the application Backend Updates to the backend of the application Ready For Review PR is ready for code review Database labels May 31, 2024
@bergomi02 bergomi02 requested a review from neophyte57 May 31, 2024 22:11
@bergomi02 bergomi02 self-assigned this May 31, 2024
Comment thread prime-dotnet-webapi/Controllers/HealthAuthoritiesController.cs Fixed
@neophyte57

Copy link
Copy Markdown
Contributor

Testing this locally, I have these Care Types and Vendors
image

But can't seem to associate a Vendor to the new Care Type "Funny Care"?
image

@bergomi02

Copy link
Copy Markdown
Collaborator Author

Testing this locally, I have these Care Types and Vendors image

But can't seem to associate a Vendor to the new Care Type "Funny Care"? image

Good catch. it should be fixed.

<app-page-subheader>
<ng-container appPageSubheaderTitle>{{ title }}</ng-container>
<ng-container appPageSubheaderSummary>
Identify the Care Type Vendor associated with this Health Authority.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to "Identify the Vendor(s) associated with each Care Type."

@neophyte57

Copy link
Copy Markdown
Contributor

Testing locally ... when "Funny Care" was associated with CareConnect, I started a HA Site submission. But then, as admin, I switched Funny Care to BDM
image

However, now for the Site, I can "Save and Continue" without selecting any Vendor:
image

@sonarqubecloud

sonarqubecloud Bot commented Oct 27, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

return NotFound($"Health Authority not found with id {healthAuthorityId}");
}

if (careTypeVendors.Count() == 0)
Comment on lines +260 to +271
foreach (var ctv in careTypeVendors.OrderBy(ctv => ctv.CareType))
{
if (!existingCareTypeVendors.Any(ectv => ectv.HealthAuthorityCareType.CareType == ctv.CareType &&
ectv.HealthAuthorityVendor.VendorCode == ctv.VendorCode))
{
_context.HealthAuthorityCareTypeToVendors.Add(new HealthAuthorityCareTypeToVendor
{
HealthAuthorityCareTypeId = haCareTypes.First(ct => ct.CareType == ctv.CareType).Id,
HealthAuthorityVendorId = haVendors.First(v => v.VendorCode == ctv.VendorCode).Id,
});
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Updates to the backend of the application Database Frontend Updates to the frontend of the application Ready For Review PR is ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants