fix(kyrgyz): remove references to discontinued live radio route - #14339
Open
vdeksne wants to merge 6 commits into
Open
fix(kyrgyz): remove references to discontinued live radio route#14339vdeksne wants to merge 6 commits into
vdeksne wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Kyrgyz live radio route references (now discontinued/redirecting) so that tests and release documentation reflect current product behaviour.
Changes:
- Deleted the Kyrgyz live radio integration test and its Jest snapshot.
- Updated the LiveRadioPage unit test to use Uzbek fixture data for the “no schedule” case instead of Kyrgyz.
- Removed Kyrgyz live radio links from the Simorgh release info documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/integration/pages/liveRadio/kyrgyz/canonical.test.ts | Removes the obsolete Kyrgyz live radio canonical integration coverage. |
| ws-nextjs-app/integration/pages/liveRadio/kyrgyz/snapshots/canonical.test.ts.snap | Removes the associated snapshot data for the deleted integration test. |
| src/app/pages/LiveRadioPage/index.test.tsx | Stops importing/using the Kyrgyz live radio fixture; switches to Uzbek for the “no schedule” assertion. |
| docs/Simorgh-Release-Info.mdx | Removes Kyrgyz live radio URLs from release verification links. |
| .eslintrc.js | Adds an import/no-unresolved rule (with an ignore for timezone side-effect imports). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vdeksne
force-pushed
the
WS-1348-remove-kyrgyz-live-radio
branch
from
August 25, 2026 09:03
ab81255 to
a8335b1
Compare
vdeksne
marked this pull request as ready for review
August 25, 2026 09:10
SantaZena
approved these changes
Aug 26, 2026
elvinasv
reviewed
Aug 26, 2026
| }, | ||
| ]; | ||
| }, | ||
| async redirects() { |
Member
There was a problem hiding this comment.
@vdeksne, to double check, why do we need this redirect? Normally redirections are handled by the Belfrage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-1348
Summary
Remove references to Kyrgyz live radio now that the route redirects to the Kyrgyz home page and is no longer broadcasting. This keeps the codebase, docs, and tests aligned with the current product behaviour.
Additional change
This PR also configures ESLint's
import/no-unresolvedrule to ignore imports matching#psammead/moment-timezone-include/tz/.These timezone modules are generated and intentionally excluded from version control. In clean CI checkouts, ESLint cannot resolve them when validating service configuration files, causing lint failures across services. The ignore is scoped only to these generated timezone imports.
Testing
yarn test:lintCode changes
Testing
yarn test:unit -- src/app/pages/LiveRadioPage/index.test.tsxyarn test:unitUseful Links