Bring tar runfiles up to feature parity with pkg_files.runfiles. #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@aiuto what's needed to make this draft Ready for review? We're eager to get this in to fix python images. |
Collaborator
Author
Contributor
|
@aiuto both PRs are merged, is there anything we could do to help with this? |
Collaborator
Author
|
I'm waiting on #784 so CI can
be green again.
…On Mon, Nov 20, 2023 at 10:42 AM Diego Ortin ***@***.***> wrote:
@aiuto <https://github.com/aiuto> both PRs are merged, is there anything
we could do to help with this?
—
Reply to this email directly, view it on GitHub
<#754 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHCZTEFVZURSOGMMSFDYFN263AVCNFSM6AAAAAA44DUYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGMYTCMRYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The bulk of the change is to have pkg_tar use pkg_files%add_label_list to process srcs. That brings it in conformance with pkg_files and pkg_zip. This changes the behavior of runfiles to be useful, but it is a breaking change. Fixes: bazelbuild#153 Fixes: bazelbuild#579 Other bits: - do not fail verify_archive_test without a min_size or max_size - change `data` file in the sample executable from BUILD to foo.cc so that it is easier to disambiguate from other files. - fix bug in runfiles support where files were not added to file_deps list. - fix bug in runfiles support where the runfiles base was not computed correctly. - buildifier to make the linters happy.
cgrindel
approved these changes
Nov 28, 2023
|
will this change be pulled into an official release sometime soon? looks like the latest was from may |
Collaborator
Author
|
Now that we are past the bazel 7 release and the holidays it might be time
for a new one.
It needs a little CI work first to make sure we are testing with bazel 6
(wihout bzlmod)
and 7 with both bzlmod and without.
Just a matter of an afternoon of grunt work.
…On Mon, Jan 1, 2024 at 5:11 PM Connor Latham ***@***.***> wrote:
will this change be pulled into an official release sometime soon? looks
like the latest was from may
—
Reply to this email directly, view it on GitHub
<#754 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHCV67TBH5WWB2JVVQDYMMYAZAVCNFSM6AAAAAA44DUYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGUYDANZTGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring tar runfiles up to feature parity with pkg_files.runfiles.
The bulk of the change is to have pkg_tar use
pkg_files%add_label_listto processsrcs. That brings it in conformance with pkg_files and pkg_zip. This changes the behavior of runfiles to be useful, but it is a breaking change.Fixes: #153
Fixes: #579
Other bits:
datafile in the sample executable from BUILD to foo.cc so that it is easier to disambiguate from other files.RELNOTES: Improved runfiles support in pkg_tar. Breaking change: we now require a Bazel that supports lambdas.