chore(deps): update dependency rules_go to v0.62.0 - autoclosed - #808
Closed
renovate[bot] wants to merge 1 commit into
Closed
chore(deps): update dependency rules_go to v0.62.0 - autoclosed#808renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
renovate
Bot
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
July 23, 2026 17:16
fmeum
pushed a commit
that referenced
this pull request
Aug 3, 2026
…#810) ## Summary All `external_test (…, latest, true, …)` CI jobs have been failing since bazelisk `latest` moved from Bazel 9.1.1 to 9.2.0 (~2026-07-14). This is what is breaking the currently open renovate PRs #804–#808 — in the failing runs 122 of 123 tests pass; the job fails only on an analysis error. Bazel 9.2 makes duplicate constraint values in `target_compatible_with` a hard analysis-time error. rules_go's `tests/core/cgo:binary_with_rpath` lists both `@platforms//os:linux` and `@platforms//os:macos` (OR was intended, AND was written), so analyzing `@io_bazel_rules_go//tests/core/cgo:all` fails with: ``` ERROR: .../external/rules_go+/tests/core/cgo/BUILD.bazel:346:10: Duplicate constraint values detected: constraint_setting @@platforms//os:os has [@@platforms//os:linux, @@platforms//os:osx] ``` Under Bazel <= 9.1 the target was silently skipped as incompatible-everywhere, which is why this only surfaced now. The target is still broken on rules_go master, so upgrading rules_go (#807/#808) does not help. ## Changes - Add `tests/rules_go-fix-binary_with_rpath-constraints.patch`, rewriting the attribute to the canonical OR idiom (`select` with `@platforms//:incompatible` default), applied via `single_version_override` in `tests/MODULE.bazel`. No version pin, so renovate bumps keep working; the patch applies cleanly to rules_go 0.61.1, 0.62.0 and current master. No test is disabled — on the contrary, `binary_with_rpath` now actually builds on linux/macos for the first time. - Fix the `generate_imported_dylib.sh` invocation in `run_external_tests.sh`: it has always failed with `cc: fatal error: no input files` (masked by `|| echo`) because `IMPORTED_C_PATH` is never set anywhere. Default to the `imported.c` next to the script and output into the cgo package directory. This was never the CI blocker (`dylib_test` is tagged `manual` and never runs), but the ERROR line in every log was a red herring while debugging this. Follow-up: the proper fix belongs in bazel-contrib/rules_go (`tests/core/cgo/BUILD.bazel`); the local patch can be dropped once a fixed rules_go release is available. ## Test plan Verified locally on macOS arm64 with Bazel 9.2.0: - Without the patch: reproduced the exact CI failure (43/44 targets analyzed). - With the patch: all 44 targets in `@io_bazel_rules_go//tests/core/cgo:all` analyze cleanly, and `binary_with_rpath` builds successfully with the LLVM toolchain. - The fixed dylib prep invocation generates `libimported.dylib` / `libversioned.*` as intended.
renovate
Bot
force-pushed
the
renovate/rules_go-0.x
branch
from
August 3, 2026 19:19
c6a553e to
eba7bc8
Compare
helly25
added a commit
that referenced
this pull request
Aug 4, 2026
## Summary Collects all outstanding renovate dependency upgrades, which were previously blocked by the Bazel 9.2 / rules_go analysis error fixed in #810. Each commit is the corresponding renovate PR cherry-picked onto current master: | PR | Dependency | Version | |----|------------|---------| | #804 | rules_java (WORKSPACE) | 9.6.1 → 9.7.0 | | #805 | aspect_bazel_lib (WORKSPACE) | 3.5.0 → 3.7.1 | | #806 | bazel_skylib (MODULE + toolchain/deps.bzl) | 1.9.0 → 1.9.2 | | #776 | boringssl (MODULE + WORKSPACE) | 0.20260526.0 → 0.20260803.0 | | #787 | rules_rust (MODULE) | 0.70.0 → 0.73.0 | | #807 | io_bazel_rules_go (WORKSPACE) | 0.61.1 → 0.62.0 | | #808 | rules_go (MODULE) | 0.61.1 → 0.62.0 | Those PRs can be closed once this merges (renovate should detect the versions are present). ## Verification (local, macOS arm64, Bazel 9.2.0, bzlmod) - `@io_bazel_rules_go//tests/core/cgo:all`, `@rules_rust//test/unit/{interleaved_cc_info,native_deps}:all`, `@boringssl//...` and `//foreign:pcre` all analyze cleanly (106 targets) — confirming the #810 rules_go patch applies to 0.62.0 and the boringssl patch applies to 0.20260803.0. - The test targets excluded in `run_external_tests.sh` all still exist under rules_rust 0.73.0 / rules_go 0.62.0, so target-pattern expansion stays valid. Note: rules_go 0.62.0 has a known Bazel 9 issue with duplicate mingw constraints in its windows cgo platforms (bazel-contrib/rules_go#4665); it should not trigger here since nothing targets Windows, but flagging it in case CI says otherwise. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.61.1→0.62.0Release Notes
bazelbuild/rules_go (rules_go)
v0.62.0Author: zbarsky-bot
MODULE.bazelcodeWORKSPACEcodeWhat's Changed
GoLinkactions togo_linkexec group by @michaelm-openai in bazel-contrib#4630go_linkexec group to go_test by @michaelm-openai in bazel-contrib#4632New Contributors
Full Changelog: bazel-contrib/rules_go@v0.61.1...v0.62.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.