Make java library earlier on classpath #1797
Merged
+73
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Farid Zakaria <[email protected]>
vinnybod
requested review from
WojciechMazur,
mbland and
simuons
as code owners
vinnybod
commented
Dec 2, 2025
Collaborator
WojciechMazur
left a comment
WojciechMazur
left a comment
There was a problem hiding this comment.
Thank you for these changes, looks good. I've left some 2 comments regarding only minor improvements
WojciechMazur
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a scala_library with some java files where I would like to override the class for a particular dependency (i.e. something from @maven//).
In order for this to work, the Java file needs to be first on the classpath.
@rules_scala seems to be placing the generated java_library at the end of the CLASSPATH.
This change makes it so that it's first.
This is a copy of #1752 but with a test added