Skip to content

Add no-remote-cache tags to intermediate artifacts so rules_jvm_external works with --remote_download_toplevel set #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cheister wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add no-remote-cache tags to intermediate artifacts so rules_jvm_external works with --remote_download_toplevel set #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions private/dependency_tree_parser.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def _genrule_copy_artifact_from_http_file(artifact, visibilities):
"genrule(",
" name = \"%s_extension\"," % http_file_repository,
" srcs = [\"@%s//file\"]," % http_file_repository,
" tags = [\"no-remote-cache\"],",
" outs = [\"%s\"]," % file,
" cmd = \"cp $< $@\",",
]
Expand Down Expand Up @@ -182,6 +183,7 @@ def _generate_target(

coordinates = artifact.get("maven_coordinates", artifact["coordinates"])
target_import_string.append("\ttags = [")
target_import_string.append("\t\t\"no-remote-cache\",")
target_import_string.append("\t\t\"maven_coordinates=%s\"," % coordinates)
if len(artifact["urls"]):
target_import_string.append("\t\t\"maven_url=%s\"," % artifact["urls"][0])
Expand Down