Skip to content

Add instance for ShortByteString#34

Open
ulidtko wants to merge 2 commits intobasvandijk:masterfrom
ulidtko:add-ShortByteString
Open

Add instance for ShortByteString#34
ulidtko wants to merge 2 commits intobasvandijk:masterfrom
ulidtko:add-ShortByteString

Conversation

@ulidtko
Copy link
Copy Markdown

@ulidtko ulidtko commented May 13, 2024

This fixes #23.

Not sure about the test... please LMK if you want the #ifdef's in test code as well, or any other approach.

Tested on GHC 9.6.4 (only), with bytestring-0.11.5.3:

λ
λλ ➔ mk @ShortByteString "asdf" == mk "aSdF"
True
λ
λλ ➔ mk @ShortByteString "asdf" == mk "aSdF."
False

cc @basvandijk @winterland1989 please review.

ulidtko added 2 commits May 13, 2024 15:36
This definition is compatible as far back as import Data.Semigroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI ByteString is slow

1 participant