integrate global search for applications and menu items #2461
+601
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, it's a nice feature @RushiChaganti |
Open
bin/omarchy-menu
Outdated
| go_to_menu() { | ||
| case "${1,,}" in | ||
| *apps*) walker -p "Launch…" ;; | ||
| *search*) /omarchy-global-search ;; |
There was a problem hiding this comment.
this is a typo, correct?
Suggested change
| *search*) /omarchy-global-search ;; | |
| *search*) omarchy-global-search ;; |
Comment on lines
464
to
466
| if [[ -z "$selection" ]]; then | ||
| $HOME/test/test.sh | ||
| else |
There was a problem hiding this comment.
is this supposed to be commited?
bin/omarchy-menu
Outdated
Comment on lines
471
to
476
| LAUNCHER="${LAUNCHER:-$HOME/test/test.sh}" | ||
| launch_unified_search() { | ||
| export OMARCHY_MENU_ACTIVE=1 | ||
| "$LAUNCHER" unified | ||
| unset OMARCHY_MENU_ACTIVE | ||
| } |
There was a problem hiding this comment.
again, I'm supposing test.sh is some WIP?
There was a problem hiding this comment.
No, it’s finished. I’ve been working on the file and renamed it to omarchy-global-search, but I’ve forgotten parts of the code.
|
Hey @celsobenedetti Fixed the issue, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a global search that integrates both applications and menu items into a single searchable interface.
Details:
Applications and menu entries are now combined into one seamless search experience.
Search results display inline counts for better clarity.
The global search can be accessed by pressing Esc from within any menu (as modifying other keybindings would require extensive structural changes — following @dhh request for minimal modification).
It remains accessible from the main menu as well.
Notes:
This code was collaboratively developed with the assistance of various LLMs and has been thoroughly reviewed and tested by a human to ensure correctness and reliability.
Although it has been tested thoroughly, some minor bugs may still exist.
You can comment on this PR if you encounter any issues — I’ll address them promptly.
Open for suggestions and feedback for further improvements.
Global_search_demo.mp4