Preserve ordered list starting number#713
Open
mdiebolt wants to merge 4 commits intobasecamp:mainfrom
Open
Conversation
In order for `ol` list elements to respect the numbers they were authored with we need to make sure that the `start` attribute makes it through dom_purify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Poll Everywhere we have a use-case where we have multiple Lexxy editors on the same page representing choices to a multiple choice question. Our customers want to be able to mark choices with 1., 2., 3. and have them styled as a list.
Prior to this change the editor rendered the lists as authored but on save the list element
startattribute would get sanitized away, resulting in each choice showing1..This PR adds
startto both the DOM purify and ActionText attribute allowlists.Before
After
