Skip to content

Ruby 4#2173

Open
jeremy wants to merge 1 commit intomainfrom
ruby-4
Open

Ruby 4#2173
jeremy wants to merge 1 commit intomainfrom
ruby-4

Conversation

@jeremy
Copy link
Member

@jeremy jeremy commented Dec 17, 2025

@jeremy jeremy force-pushed the ruby-4 branch 11 times, most recently from 1c93556 to 41a31d3 Compare December 18, 2025 22:15
@jeremy jeremy force-pushed the ruby-4 branch 5 times, most recently from 1ebb12d to 97650f9 Compare January 2, 2026 20:00
Copilot AI review requested due to automatic review settings February 4, 2026 00:46
* Bundler 4.0.3
* Awaiting platform-specific gem: ffi, nokogiri, sqlite3, thruster
* Gem upgrades for Ruby 4 compat
  * rubocop 1.82.0 for rubocop/rubocop#14644
  * web-push 3.1.0 for pushpad/web-push#19
* Git sources for fixes and pending releases
  * rinku: vmg/rinku#97
  * rubocop: rubocop/rubocop#14644
  * web-push: for pushpad/web-push#19
* Many platform-specific gems aren't compiled for Ruby 4 yet, which
  triggers a Bundler bug wherein it selects a chooses an imcompatible
  platform-specific gem rather than falling back to the ruby platform
  and compiling. Fix: ruby/rubygems#9211
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the project from Ruby 3.4.7 to Ruby 4.0.0, along with Bundler 4.0.3 and various gem updates required for Ruby 4 compatibility.

Changes:

  • Ruby version updated to 4.0.0 across all configuration files (.ruby-version, Dockerfiles)
  • Bundler upgraded to 4.0.3 with new configuration for default CLI command
  • Gem dependencies updated for Ruby 4 compatibility (rubocop >= 1.82.0, web-push >= 3.1.0)
  • Platform fallback to generic "ruby" platform added to work around missing platform-specific gems
  • CGI gem explicitly added as it was removed from Ruby 4.0 stdlib
  • Rinku gem sourced from Git branch with Ruby 4 export fix

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.ruby-version Updates Ruby version from 3.4.7 to 4.0.0
Dockerfile Updates Ruby version in base image to 4.0.0
saas/Dockerfile Updates Ruby version in SaaS base image to 4.0.0
Gemfile Adds ruby version declaration, updates gem constraints for rubocop and web-push, adds cgi gem for stdlib removal
Gemfile.saas Adds rinku git source dependency for Ruby 4 fix
Gemfile.lock Updates to Bundler 4.0.3, Ruby 4.0.0, adds ruby platform, updates gem versions including platform-specific gems
Gemfile.saas.lock Updates to Bundler 4.0.3, Ruby 4.0.0, adds ruby platform and rinku git source, updates gem versions
.rubocop.yml Updates TargetRubyVersion to 4.0 and adds ParserEngine: parser_prism
bin/setup Adds Bundler config for default_cli_command setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gem "selenium-webdriver"
gem "webmock"
gem "vcr"
gem "cgi" # Indirect vcr dep removed Ruby 4.0 stdlib
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment has a minor grammatical issue. It should read "removed from Ruby 4.0 stdlib" (with "from" added) for clarity.

Suggested change
gem "cgi" # Indirect vcr dep removed Ruby 4.0 stdlib
gem "cgi" # Indirect vcr dep removed from Ruby 4.0 stdlib

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants