feat(web): add @next/third-parties to layout #2709
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adds
@next/third-parties
to better manage Google Analytics/Tag Manager ID in main Next layout, rather than using scripts withdangerouslySetInnerHTML
.If you did want to add targeted, custom events in the future for any areas of the site you could do this a lot easier with the
sendGAEvent
orsendGTMEvent
primitive as well.Notes to reviewers
Note this package is still technically considered experimental by the Next team, so if this is no good please feel free to close this PR.
How has it been tested?
Have you tested the following pages?
BaseWeb
I don't have access to that GA ID obviously, but tried on one I have locally and it seems to be working okay!