Skip to content

Conversation

et0and
Copy link

@et0and et0and commented Oct 12, 2025

What changed? Why?

Adds @next/third-parties to better manage Google Analytics/Tag Manager ID in main Next layout, rather than using scripts with dangerouslySetInnerHTML.

If you did want to add targeted, custom events in the future for any areas of the site you could do this a lot easier with the sendGAEvent or sendGTMEvent primitive as well.

Notes to reviewers
Note this package is still technically considered experimental by the Next team, so if this is no good please feel free to close this PR.

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

I don't have access to that GA ID obviously, but tried on one I have locally and it seems to be working okay!

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 12, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Copy link

vercel bot commented Oct 12, 2025

@et0and is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants