chore: dont err if we cant simulate #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Dec 2, 2025
| .unwrap_or_else(|_| { | ||
| // TODO: in the future, we should return the error | ||
| warn!(message = "Bundle simulation failed, using default response", bundle_hash = %bundle_hash); | ||
| MeterBundleResponse::default() |
Contributor
Author
There was a problem hiding this comment.
maybe default_with_hash() to use the bundle hash here? not sure if it matters
but also dont want to make this fn look like something to frequently use
danyalprout
approved these changes
Dec 3, 2025
Collaborator
danyalprout
left a comment
danyalprout
left a comment
There was a problem hiding this comment.
would be nice to add a test for this if possible
danyalprout
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.