feat: enable datadog apm tracing #32
Conversation
crates/ingress-rpc/src/service.rs
Outdated
| if let Err(e) = self.queue.publish(&bundle, sender).await { | ||
| let span = | ||
| span!(tracing::Level::INFO, "span_publish", transaction = %transaction.tx_hash()); | ||
| if let Err(e) = self.queue.publish(&bundle, sender).instrument(span).await { |
There was a problem hiding this comment.
i can see the span! info logs but they don't show up as traces
There was a problem hiding this comment.
hoping that opentelemetry_datadog is the fix to sending traces to the agent properly ... will verify
| #[derive(Debug, Clone)] | ||
| struct AgentBasedSampler; | ||
|
|
||
| impl ShouldSample for AgentBasedSampler { |
There was a problem hiding this comment.
with this addition, it now brings back the error:
Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
prior to implementing ShouldSample trait, it didn't panic.
in both scenarios, traces are still not showing up in APM though
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
related: #22 , #29
Overview
Distributed tracing will let us visualize in a flamegraph format of where a txn spends the most time in TIPS.
This would be particularly helpful in terms of optimizing certain TIPS components.
Resources
References
TODOs